[PWGJE] Adding file jetHadronsPID.cxx and it's workflow by MyFavoriteGitHub · Pull Request #16012 · AliceO2Group/O2Physics

MyFavoriteGitHub · 2026-04-28T18:39:10Z

The reason for this pull request is to create a new analysis of PID in jets as a student's team with the collaboration of Warsaw University of Technology Physics department .
This is the first pull request from this account, I hope all the technical requirements are met.
If you have any questions, please contact me on leonard.lorenc@cern.ch

github-actions · 2026-04-28T18:39:28Z

O2 linter results: ❌ 15 errors, ⚠️ 2 warnings, 🔕 0 disabled

vkucera · 2026-04-29T08:23:22Z

@MyFavoriteGitHub your username does not really identify you well in the collaboration.

vkucera · 2026-04-29T08:24:18Z

+#include "Framework/AnalysisTask.h"
+#include "Framework/HistogramRegistry.h"
+#include "Framework/Logger.h"
+#include "Framework/runDataProcessing.h"
+#include "ReconstructionDataFormats/DCA.h"
+#include "ReconstructionDataFormats/PID.h"
+#include "ReconstructionDataFormats/Track.h"


Fix the format

vkucera · 2026-04-29T08:26:44Z

+    double px2 = px * px, py2 = py * py, pz2 = pz * pz;
+    double pz4 = pz2 * pz2;
+
+    if (px == 0 && py == 0) {


You should not compare double to 0.

vkucera · 2026-04-29T08:27:26Z

+    registryData.add("mc_sec_proton_pt", "Reconstructed Proton Secondaries", HistType::kTH1F, {{120, 0.0, 4.0, "#it{p}_{T} (GeV/#it{c})"}});
+  }
+
+  void getPerpendicularDirections(const TVector3& p, TVector3& u1, TVector3& u2)


Please put some documentation concerning the purpose of this function and the math involved.

vkucera · 2026-04-29T08:28:07Z

+    u2.SetXYZ(u2x, (-pz2 - px * u2x) / py, pz);
+  }
+
+  double getDeltaPhi(double a1, double a2)


Don't reinvent the wheel. Use RecoDecay::constrainAngle.

vkucera · 2026-04-29T08:28:50Z

+  }
+
+  template <typename TrackIts>
+  bool hasITSHit(const TrackIts& track, int layer)


Unfortunate name.

vkucera · 2026-04-29T08:29:33Z

+  bool hasITSHit(const TrackIts& track, int layer)
+  {
+    int ibit = layer - 1;
+    return (track.itsClusterMap() & (1 << ibit));


This is not a bool expression.

vkucera · 2026-04-29T08:30:16Z

+  }
+
+  template <typename JetTrack>
+  bool passedTrackSelectionForJetReconstruction(const JetTrack& track)


Why don't you use the central track selection?

vkucera · 2026-04-29T08:32:03Z

+      bool passTpcPi = (std::abs(track.tpcNSigmaPi()) <= 3.0);
+      bool passTofPi = track.hasTOF() && (std::abs(track.tofNSigmaPi()) <= 3.0);
+
+      bool passTpcKa = (std::abs(track.tpcNSigmaKa()) <= 3.0);
+      bool passTofKa = track.hasTOF() && (std::abs(track.tofNSigmaKa()) <= 3.0);
+
+      bool passTpcPr = (std::abs(track.tpcNSigmaPr()) <= 3.0);
+      bool passTofPr = track.hasTOF() && (std::abs(track.tofNSigmaPr()) <= 3.0);


Avoid hard-coded and duplicated constants.

nzardosh · 2026-04-29T08:20:00Z

+/// \author Małgorzata Janik malgorzata.janik@cern.ch
+/// \author Daniela Ruggiano daniela.ruggiano@cern.ch
+
+#include "PWGJE/Core/JetBkgSubUtils.h"


@vkucera can you check the includes please?

nzardosh · 2026-04-29T08:23:07Z

+        continue;
+
+      fastjet::PseudoJet fourMomentum(track.px(), track.py(), track.pz(), track.energy(MassPionCharged));
+      fourMomentum.set_user_index(id);


this is probably fine but is it the same as using globalIndex()? Probably globalIndex is safer in case at some point you accidentally add a cut before idx++

nzardosh · 2026-04-29T08:26:19Z

+        continue;
+
+      double normalizedJetArea = jet.area() / (PI * rJet * rJet);
+      if (applyAreaCut && (!isppRefAnalysis) && normalizedJetArea > maxNormalizedJetArea)


you apply a maximum cut instead of minimum?

nzardosh · 2026-04-29T08:27:51Z

+    if (fjParticles.empty())
+      return;
+
+    fastjet::JetDefinition jetDef(fastjet::antikt_algorithm, rJet);


why do you not use the common jet finder?

nzardosh · 2026-04-29T08:28:41Z

+    static constexpr double DcaxyMaxTrackPar0 = 0.0105;
+    static constexpr double DcaxyMaxTrackPar1 = 0.035;
+    static constexpr double DcaxyMaxTrackPar2 = 1.1;
+    static constexpr double DcazMaxTrack = 2.0;


the dca cuts for kets and PID are very different, is this safe?

nzardosh · 2026-04-29T08:30:10Z

+    if (requireIsVertexTOFmatched && !collision.selection_bit(o2::aod::evsel::kIsVertexTOFmatched))
+      return;
+
+    for (auto const& mcpart : mcParticles) {


this loops over every mc particle in the dataframe, not just the ones associated to the mcCollision matched to that particular collision

…quest

MyFavoriteGitHub and others added 9 commits April 27, 2026 16:49

Add jetHadronsPID and update CMakeLists

ec18b06

small changes to jetHadronsPID

b7d49f8

fixing pid in jetHadronsPID

db4168c

more changes to pid

4464823

add historams for hadrons in jet and ue

267a9fa

fixing code and adding mc process

afe2378

Update MC and jet histograms

e681162

Rename DPL workflow from 'pid-hadrons-in-jets' to 'jet-hadrons-pid'

d989f30

Fixing formating and adding description

25b7de0

MyFavoriteGitHub requested review from alibuild, fjonasALICE, maoyx, mfasDa, mhemmer-cern, nzardosh and raymondEhlers as code owners April 28, 2026 18:39

github-actions Bot added the pwgje label Apr 28, 2026

github-actions Bot changed the title ~~[PWGJE] Adding file jetHadronsPID.cxx and it's workflow~~ [PWGJE] Adding file jetHadronsPID.cxx and it's workflow Apr 28, 2026

alibuild mentioned this pull request Apr 28, 2026

Please consider the following formatting changes to #16012 MyFavoriteGitHub/O2Physics#1

Closed

MyFavoriteGitHub marked this pull request as draft April 28, 2026 18:42

Changing formating in jetHadronsPid.cxx and in CMakeLists.txt

8b4ef7b

MyFavoriteGitHub marked this pull request as ready for review April 28, 2026 19:10

vkucera reviewed Apr 29, 2026

View reviewed changes

nzardosh reviewed Apr 29, 2026

View reviewed changes

nzardosh marked this pull request as draft April 29, 2026 08:32

Changing code in jetHadronsPid.cxx according with comments on pull re…

371c30d

…quest

Conversation

MyFavoriteGitHub commented Apr 28, 2026

Uh oh!

github-actions Bot commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vkucera commented Apr 29, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented Apr 28, 2026 •

edited

Loading